]> dgit.raspbian.org Git - gnome-shell.git/commitdiff
overview: Set searchEntry offscreen-redirected always
authorDaniel van Vugt <daniel.van.vugt@canonical.com>
Wed, 23 Oct 2019 04:18:20 +0000 (12:18 +0800)
committerFlorian Müllner <florian.muellner@gmail.com>
Tue, 29 Oct 2019 15:41:06 +0000 (15:41 +0000)
This corrects weird-looking blending visible as it fades out when the
overview closes. Previously the entry's dark background would drown out
the text as it fades out, but now they maintain a consistent contrast ratio
during the fade.

There's no noticeable change in performance, but in theory it should be
faster as text entries don't change at full frame rate. So stage redraws
will usually have a cached searchEntry drawn and require less effort.
Though the main purpose here is to correct the appearance.

https://gitlab.gnome.org/GNOME/gnome-shell/merge_requests/778

js/ui/overview.js

index 0b547c2be993d27b21217f33ea60baf7d0a81328..4775f1bd6d76c755b63f5efc35a93a276398b875 100644 (file)
@@ -108,6 +108,7 @@ class OverviewActor extends St.BoxLayout {
             track_hover: true,
             can_focus: true
         });
+        this._searchEntry.set_offscreen_redirect(Clutter.OffscreenRedirect.ALWAYS);
         let searchEntryBin = new St.Bin({
             child: this._searchEntry,
             x_align: St.Align.MIDDLE